Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also exclude backport-open label from branch diff #440

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 9, 2020

We should also be excluding PRs with the backport-open-vX.Yx label from branch diffs.

cc @targos @BridgeAR

@codebytere codebytere requested review from BridgeAR and targos June 9, 2020 15:42
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #440 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files          21       21           
  Lines        1496     1496           
=======================================
  Hits         1154     1154           
  Misses        342      342           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bc3fc...f0ff3cc. Read the comment docs.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my custom script, I also exclude baking-for-lts.

@codebytere codebytere merged commit af4c72c into nodejs:master Jun 9, 2020
@codebytere codebytere deleted the exclude-backport-open branch June 9, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants