Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(update-v8): remove abseil-cpp from V8 dependencies #567

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

targos
Copy link
Member

@targos targos commented Oct 4, 2021

It was removed upstream because of issues with GCC.

It was removed upstream because of issues with GCC.
@targos targos requested a review from richardlau October 4, 2021 06:49
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #567 (bb4c583) into main (ba58098) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files          35       35           
  Lines        1750     1750           
=======================================
  Hits         1445     1445           
  Misses        305      305           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba58098...bb4c583. Read the comment docs.

@targos targos merged commit 8ccf184 into nodejs:main Oct 4, 2021
@targos targos deleted the no-abseil branch October 4, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants