-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: remove unmarked DEP0XXX handler #685
Conversation
The deprecation numbers are linted by the `test-doc` test suite, and using `DEP0XXX` would be flagged as invalid before the PR can land.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
=======================================
Coverage 83.38% 83.38%
=======================================
Files 37 37
Lines 4158 4158
=======================================
Hits 3467 3467
Misses 691 691 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Is that true on all supported release lines? |
It seems that nodejs/node#41992 hasn't been backported to v14.x, so I guess this should wait for v14.x to be officially EOL. |
Thank you for checking. I suspect it's highly unlikely we'll deprecate something new in Node.js 14 before it reaches End-of-Life. I'd be okay landing if other @nodejs/releasers agree, otherwise we can wait. |
SGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@aduh95 there's a conflict now. |
The deprecation numbers are linted by the
test-doc
test suite, and usingDEP0XXX
would be flagged as invalid before the PR can land.