Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v8): do not ignore failures when running git #809

Merged
merged 1 commit into from
May 21, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 12, 2024

Also always use forceRunAsync because runAsync exits the process on error.

Also always use `forceRunAsync` because `runAsync` exits the process on error.
@targos
Copy link
Member Author

targos commented May 18, 2024

@nodejs/node-core-utils

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to test it, but the code diff looks all right

@targos
Copy link
Member Author

targos commented May 21, 2024

I tested these scenarios locally:

  • Major update
  • Minor update (already up-to-date)
  • Minor update (with patch)
  • Backport (patch applies cleanly)
  • Backpor (patch doesn't apply cleanly)

@targos targos merged commit 9f8df53 into nodejs:main May 21, 2024
11 checks passed
@targos targos deleted the run-async branch May 21, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants