Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ignore-date when rebasing #834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jul 17, 2024

The Node.js commit history does not have chronological dates, so a more recent commit can have an older timestamp. This is causing solutions like Codecov to have unreliable coverage reports.

059f2f43b8      Afanasii Kurakin        Wed Jul 10 20:41:34 2024 +1000  doc: add OpenSSL security level to TLS docs
661ae62ab8      Cloyd Lau       Wed Jul 10 17:24:43 2024 +0800  doc: update `scroll-padding-top` to 4rem
eaffed65f0      Igor Sheludko   Mon Jun 24 10:42:18 2024 +0200  src: fix implementation of `PropertySetterCallback`
e849dd6632      Node.js GitHub Bot      Wed Jul 10 07:13:36 2024 +0300  meta: move one or more collaborators to emeritus
b4e8f1b6bb      Colin Ihrig     Tue Jul 9 16:33:38 2024 -0400   lib,src,test,doc: add node:sqlite module
1a1639de3e      Chengzhong Wu   Sun Jun 23 23:31:33 2024 +0100  deps: V8: cherry-pick 9ebca66a5740
d15f514077      Joyee Cheung    Sun Jul 7 20:22:17 2024 +0200   deps: V8: cherry-pick e061cf9970d9
307430e490      Yagiz Nizipli   Tue Jul 9 10:38:01 2024 -0400   fs: improve error performance of `fs.dir`
c0962dc3bf      Chengzhong Wu   Thu Jun 20 10:14:57 2024 +0100  vm,src: add property query interceptors
213fea0c55      Chengzhong Wu   Thu Jun 20 00:01:54 2024 +0100  src: remove unused ContextifyContext::WeakCallback

cc @bcoe

Unblocks nodejs/node#53891

Co-authored-by: Benjamin Coe <bencoe@gmail.com>
@anonrig
Copy link
Member Author

anonrig commented Jul 17, 2024

cc @targos @aduh95 appreciate if you could take a look at this

@aduh95
Copy link
Contributor

aduh95 commented Jul 17, 2024

Couldn't codecov use the committer date instead of the author date?

@bcoe
Copy link

bcoe commented Jul 18, 2024

Couldn't codecov use the committer date instead of the author date?

We should verify that this isn't already the case, the bug I was running into was four years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants