Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v8): handle error in git apply #851

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix(v8): handle error in git apply #851

merged 1 commit into from
Sep 3, 2024

Conversation

targos
Copy link
Member

@targos targos commented Sep 1, 2024

Capture stdout so it can be used in the catch block when there is a conflict.

Fixes: #850

Capture stdout so it can be used in the catch block when there is a conflict.

Fixes: nodejs#850
@targos
Copy link
Member Author

targos commented Sep 1, 2024

I was able to debug and open nodejs/node#54682 with this change.

@targos targos merged commit 11d0a04 into nodejs:main Sep 3, 2024
9 checks passed
@targos targos deleted the fix-850 branch September 3, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minor V8 updates are broken
3 participants