Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --releaseDate to git node release #863

Merged
merged 3 commits into from
Nov 2, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/git/release.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ const releaseOptions = {
startLTS: {
describe: 'Mark the release as the transition from Current to LTS',
type: 'boolean'
},
releaseDate: {
describe: 'Default relase date when --prepare is used. It must be YYYY-MM-DD',
type: 'string'
}
};

Expand Down
10 changes: 6 additions & 4 deletions docs/git-node.md
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ Options:
--security Demarcate the new security release as a security release [boolean]
--startLTS Mark the release as the transition from Current to LTS [boolean]
--filterLabel Filter PR by label when preparing a security release [string]
--releaseDate Default relase date when --prepare is used.
It must be YYYY-MM-DD [string]
```

### Example
Expand Down Expand Up @@ -336,7 +338,7 @@ ncu-config set waitTimeMultiApproval 48

## `git node v8`

Update or patch the V8 engine.
Update or patch the V8 engine.
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
This tool will maintain a clone of the V8 repository in `~/.update-v8/v8`
if it's used without `--v8-dir`.

Expand Down Expand Up @@ -373,7 +375,7 @@ Options:
### `git node v8 minor`

Compare current V8 version with latest upstream of the same major. Applies a
patch if necessary.
patch if necessary.
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
If the `git apply` command fails, a patch file will be written in the Node.js
clone directory.

Expand Down Expand Up @@ -462,7 +464,7 @@ It will retrieve all the triaged HackerOne reports and add creates the `vulnerab

This command updates the `vulnerabilities.json` with target date of the security release.
Example:

```sh
git node security --update-date=2023/12/31
```
Expand All @@ -471,7 +473,7 @@ Example:

This command creates a pre-release announcement for the security release.
Example:

```sh
git node security --pre-release
```
Expand Down
4 changes: 2 additions & 2 deletions lib/prepare_release.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export default class ReleasePreparation extends Session {
this.isLTS = false;
this.isLTSTransition = argv.startLTS;
this.runBranchDiff = !argv.skipBranchDiff;
this.defaultReleaseDate = argv.releaseDate ?? new Date().toISOString().slice(0, 10);
this.ltsCodename = '';
this.date = '';
this.filterLabels = argv.filterLabel && argv.filterLabel.split(',');
Expand Down Expand Up @@ -241,9 +242,8 @@ export default class ReleasePreparation extends Session {
cli.stopSpinner('Updated REPLACEME items in docs');

// Fetch date to use in release commit & changelogs.
const todayDate = new Date().toISOString().split('T')[0];
this.date = await cli.prompt('Enter release date in YYYY-MM-DD format:',
{ questionType: 'input', defaultAnswer: todayDate });
{ questionType: 'input', defaultAnswer: this.defaultReleaseDate });

cli.startSpinner('Updating CHANGELOG.md');
await this.updateMainChangelog();
Expand Down
Loading