Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to ESLint v9 and update deps #902

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

VoltrexKeyva
Copy link
Member

Closes #893.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (3cb5255) to head (84c2e1c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/cli.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   80.08%   80.05%   -0.04%     
==========================================
  Files          39       39              
  Lines        4676     4673       -3     
==========================================
- Hits         3745     3741       -4     
- Misses        931      932       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VoltrexKeyva
Copy link
Member Author

Not sure what to do about this coverage miss 🤔.

bin/git-node.js Show resolved Hide resolved
components/git/metadata.js Show resolved Hide resolved
eslint.config.js Show resolved Hide resolved
@targos
Copy link
Member

targos commented Jan 26, 2025

We don't enforce coverage

- Migrate to ESLint flat config
- Switch from `eslint-config-standard` to `neostandard` as the former
does not support ESLint v9 and seems to be unmaintained.
- Conform to the rules of the ESLint plugins/configs.
- Update all dependencies to their latest versions.
@targos targos merged commit d7f203c into nodejs:main Jan 29, 2025
11 of 13 checks passed
@VoltrexKeyva VoltrexKeyva deleted the migrate-eslint-v9 branch January 29, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change ESLint base config?
3 participants