Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis CI tests are failing on Windows #1801

Closed
cclauss opened this issue Jun 26, 2019 · 3 comments
Closed

Travis CI tests are failing on Windows #1801

cclauss opened this issue Jun 26, 2019 · 3 comments
Labels
Windows

Comments

@cclauss
Copy link
Contributor

cclauss commented Jun 26, 2019 •
edited
Loading

Travis CI currently runs tests on Windows but those tests are currently run in allow_failures mode. https://github.com/nodejs/node-gyp/blob/master/.travis.yml#L15-L20

It would be really cool to get those tests passing.
@richardlau
Copy link
Member

Travis CI currently runs tests on Windows but those tests are currently run in allow_failures mode. https://travis-ci.com/MobSF/Mobile-Security-Framework-MobSF/builds/116968308#L734

It would be really cool to get those tests passing.

Did you post the wrong link?

@cclauss
Copy link
Contributor Author

cclauss commented Jun 26, 2019

Yes. Fixed inline above.

@cclauss
Copy link
Contributor Author

cclauss commented Jul 5, 2019

@krisavi @joaocgreis If you have any cycles/ideas on how to get Windows tests working on Travis CI...

@cclauss cclauss mentioned this issue Jul 7, 2019
Closed
joaocgreis added a commit to joaocgreis/node-gyp that referenced this issue Jul 7, 2019
@joaocgreis
test: increase tap timeout
fb4d9f9 
test-addon.js includes compiling code, making the default 30 second
timeout not suitable. This increases the timeout for all platforms,
which is a potential problem everywhere, fixing the timeout that
happens on Windows.

Fixes: nodejs#1801
@joaocgreis joaocgreis mentioned this issue Jul 7, 2019
Closed
2 tasks
joaocgreis added a commit to JaneaSystems/node-gyp that referenced this issue Jul 8, 2019
@joaocgreis
test: increase tap timeout
a45bbff 
test-addon.js includes compiling code, making the default 30 second
timeout not suitable. This increases the timeout for all platforms,
which is a potential problem everywhere, fixing the timeout that
happens on Windows.

Fixes: nodejs#1801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix running Windows on Travis CI JaneaSystems/node-gyp
2 participants
@cclauss @richardlau