Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need Travis CI anymore or are GitHub Actions good enough? #2209

Closed
cclauss opened this issue Aug 31, 2020 · 4 comments
Closed

Do we need Travis CI anymore or are GitHub Actions good enough? #2209

cclauss opened this issue Aug 31, 2020 · 4 comments

Comments

@cclauss
Copy link
Contributor

cclauss commented Aug 31, 2020

https://travis-ci.com/github/nodejs/node-gyp vs. https://github.com/nodejs/node-gyp/actions

  • Node Version:
  • Platform:
  • Compiler:
  • Module:
Verbose output (from npm or node-gyp):
Paste your log here, between the backticks. It can be:
  - npm --verbose output,
  - or contents of npm-debug.log,
  - or output of node-gyp rebuild --verbose.
Include the command you were trying to run.

This should look like this:

>npm --verbose
npm info it worked if it ends with ok
npm verb cli [
npm verb cli   'C:\\...\\node\\13.9.0\\x64\\node.exe',
npm verb cli   'C:\\...\\node\\13.9.0\\x64\\node_modules\\npm\\bin\\npm-cli.js',
npm verb cli   '--verbose'
npm verb cli ]
npm info using npm@6.13.7
npm info using node@v13.9.0

Usage: npm <command>
(...)
@imatlopez
Copy link
Contributor

@cclauss is this related to #2127? I think actions is more transparent. There are two consistent failing tests (with python 2.7) on Travis and you wouldn't know that unless you go there.

@rvagg
Copy link
Member

rvagg commented Aug 31, 2020

yeah, I'd be happy to see #2209 land and ditch travis - maybe someone can help out or take over that effort?

@imatlopez
Copy link
Contributor

@codebytere do you still have the time? Maybe I can take over if you don't. Never worked with gh actions since my company's enterprise doesn't have them (just checks), but never too late to learn

@codebytere
Copy link
Member

codebytere commented Aug 31, 2020

I can try to look more for sure but feel free to push to the branch in the meantime! It should be fairly close to done - the issue i got stuck on was a funky windows one I couldn't debug locally

@rvagg rvagg closed this as completed in d1176d7 Sep 9, 2020
rvagg pushed a commit that referenced this issue Oct 14, 2020
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Matias Lopez <imatlopez@gmail.com>
PR-URL: #2210
Closes: #2127
Closes: #2209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants