Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make-fetch-happen #2756

Closed
rtritto opened this issue Nov 4, 2022 · 3 comments · Fixed by #2770
Closed

Update make-fetch-happen #2756

rtritto opened this issue Nov 4, 2022 · 3 comments · Fixed by #2770

Comments

@rtritto
Copy link

rtritto commented Nov 4, 2022

make-fetch-happen dependency needs an update to v11 because @npmcli/move-file (dependency of cacache) is deprecated.

Steps to reproduce

  • yarn init -y
  • yarn set version canary
  • yarn add node-gyp@9.3.0
Output
➤ YN0000: ┌ Resolution step
➤ YN0061: │ @npmcli/move-file@npm:2.0.1 is deprecated: This functionality has been moved to @npmcli/fs
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed
➤ YN0000: Done with warnings
@cclauss
Copy link
Contributor

cclauss commented Nov 4, 2022

@jonz94
Copy link

jonz94 commented Nov 10, 2022

One thing to consider is that make-fetch-happen@^11 is only compatible with the following semver range for node: ^14.17.0 || ^16.13.0 || >=18.0.0 (source: https://github.com/npm/make-fetch-happen/releases/tag/v11.0.0)

Updating make-fetch-happen to v11 will introduce breaking change since node-gyp@^9 still support node12:

node-gyp/package.json

Lines 36 to 38 in 2cc72be

"engines": {
"node": "^12.22 || ^14.13 || >=16"
},

@rtritto
Copy link
Author

rtritto commented Nov 10, 2022

Node v12 reached end of support (is not maintained) and is deprecated.
Node v18 can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants