Update link of gyp as Google code is shutting down #1061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would https://chromium.googlesource.com/external/gyp or https://gyp.gsrc.io/ be a better starting point for someone who doesn't know what gyp is? |
|
Oh cool, would you like me to update it? |
|
@PeterDaveHello Yes, sounds good to me. I guess you should use https://gyp.gsrc.io as that seems to be the homepage. |
|
@gibfahn thanks, if you don't mind, I just directly updated and committed on GitHub, I think you can squash them directly on GitHub, too, if you don't like it, I can clone and squash them locally or just send a new one, thanks. |
|
@PeterDaveHello looks fine to me. This needs a |
bnoordhuis
pushed a commit
that referenced
this pull request
Jan 17, 2017
PR-URL: #1061 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
bnoordhuis
approved these changes
Jan 17, 2017
|
Thanks Peter, landed in ff9a6fa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.