Upgrade semver dependency. #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
approved these changes
Feb 6, 2017
Should fix reports of "TypeError: Cannot read property 'length' of undefined" runtime exceptions where node-gyp uses a buggy version of semver due to our overly broad accepted version range. npm updated to semver@5.3.0 recently so we can too now and still share the module with npm, keeping the download small. Fixes: #1094 PR-URL: #1107 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Landed in 93d7fa8 with https://ci.nodejs.org/view/All/job/nodegyp-test-commit/38/ (all green) for good measure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix reports of "TypeError: Cannot read property 'length' of
undefined" runtime exceptions where node-gyp uses a buggy version
of semver due to our overly broad accepted version range.
npm updated to semver@5.3.0 recently so we can too now and still
share the module with npm, keeping the download small.
Fixes: #1094
CI: https://ci.nodejs.org/view/All/job/nodegyp-test-commit/35/