-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gyp: Revert quote_cmd workaround #1153
Conversation
Not your direct fault, but IMHO we should start running the |
Looks critical to me! ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that building lzma-native
(before addaleax/lzma-native#32) is fixed by this.
@rvagg should we roll out 3.6.1? Let me know if I can help. |
Support for VS2017. Chakracore support. Credit: @refack Credit: @kunalspathak
Added a regression test in #1156 |
@rvagg @bnoordhuis ping? anything I can do to help this get landed? |
@joaocgreis signed off on it. It should be good to go. |
I'm making a PR rebasing on |
@bnoordhuis Am I reading your comment correctly in that I should be landing it? I mean, I have write access as an org admin, but I would guess node-gyp has some formalities around that? |
It's no different from other repos: run CI, add commit metadata, merge. Anyone with write access can (and is welcome to) land patches. |
I assume the "secret sauce" is in actually packaging a new release? |
|
@gibfahn if you're on a roll, really should land this, it's a nasty one. |
Landed in 8a76714 |
🙏 |
Sorry to ping on a second thread, should have done it here the first time. |
published @3.6.1 |
Thank you! |
test the fix for nodejs#1151 Ref: nodejs#1153
There was a workaround added to include the cmd in quotes but with changes in
gyp
this was no longer needed. This was fixed innode-chakracore
here but #873 was not updated with the fix. Porting the fix to revert thequote_cmd
fix.Fixes: #1151