escaping Dependency FilePaths to allow spaces #1481
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is possible that there will be spaces in the path name and that currently causes things to not work
|
thanks for following up on this! If I'm not mistaken that has been actually fixed in the meantime by introducing which looks very similar to the patch of this PR. |
|
Ah cool. closing 😊 |
|
Sent a patch upstream to node to float this patch on the npm tree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is possible that there will be spaces in the path name
and that currently causes things to not work
can work out a test if this is considered a reasonable fix
/cc @fde31 who authored the patch