Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix visual studio links #1490

Closed
wants to merge 2 commits into from
Closed

doc: fix visual studio links #1490

wants to merge 2 commits into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Jul 2, 2018

Checklist
Description of change

Fixes: #1472

maclover7
maclover7 approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/59/

@rvagg
Copy link
Member

rvagg commented Aug 9, 2018

merged

@rvagg rvagg closed this Aug 9, 2018
rvagg pushed a commit that referenced this pull request Aug 9, 2018
@bzoz @rvagg
doc: fix visual studio links
1309efb 
Fixes: #1472
PR-URL: #1490
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@rvagg rvagg mentioned this pull request Aug 9, 2018
Closed
4 tasks
rvagg pushed a commit that referenced this pull request Aug 9, 2018
@bzoz @rvagg
doc: fix visual studio links
b4fe8c1 
Fixes: #1472
PR-URL: #1490
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclover7 maclover7 maclover7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzoz @rvagg @maclover7