-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow XDG OS conventions for storing data #1570
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,20 +22,20 @@ | |
"bin": "./bin/node-gyp.js", | ||
"main": "./lib/node-gyp.js", | ||
"dependencies": { | ||
"env-paths": "^1.0.0", | ||
"glob": "^7.0.3", | ||
"graceful-fs": "^4.1.2", | ||
"mkdirp": "^0.5.0", | ||
"nopt": "2 || 3", | ||
"npmlog": "0 || 1 || 2 || 3 || 4", | ||
"osenv": "0", | ||
"request": "^2.87.0", | ||
"rimraf": "2", | ||
"semver": "~5.3.0", | ||
"tar": "^3.1.3", | ||
"which": "1" | ||
}, | ||
"engines": { | ||
"node": ">= 4.0.0" | ||
"node": ">= 6.0.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is tricky. We need more buy-in from other contributors. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So far there have been no objections to dropping support for Node.js <6 for node-gyp v4 (#1519). I also suggested dropping support for Node.js 6 which will be EOL in April. |
||
}, | ||
"devDependencies": { | ||
"babel-eslint": "^8.2.5", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suffix is 'nodejs' by default, another option is:
envPaths('gyp')
which will result ingyp-nodejs
.I opted for
.cache
because I think it fits the type of data more than.data
since it is data being cached to prevent unneeded requests.