replace optparse to argparse #1591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiYugadgeter
changed the title
|
@KiYugadgeter would you mind rebasing this please so we can discuss it more cleanly? Sorry for the hassle. It probably belongs in https://github.com/refack/GYP but let's see it clearly here first. |
|
Sorry for I am beginner of git and github. Should I rebase this branch to node-gyp master branch? |
|
@KiYugadgeter yes, the master branch of this repository has changed a lot since your pull request, so you need to rebase to catch up. Hopefully there's not too much to resolve in the process. |
* add_option with add_argument for argparse * change methods methods of RegeneratableOptionParser to match argparse function name
KiYugadgeter
force-pushed
the
use_argparse
branch
from
355e787
to
57b594d
Compare
|
I have pushed new pull request that caught up. |
rvagg
pushed a commit
that referenced
this pull request
Jun 26, 2019
* add_option with add_argument for argparse * change methods methods of RegeneratableOptionParser to match argparse function name PR-URL: #1591 Reviewed-By: cclauss <cclauss@me.com>
|
landed in 82f129d |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
optparse have been deprecated since Python3.2.
also argparse work on both version (2.x and 3.x).
some methods of RegeneratableOptionParser have changed to match argparse function name.