WIP: Python 3 on Linux passes Travis CI tests #1839
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm test
passesDescription of change
The goal was to make our Travis CI tests pass on Python 3.6 on Linux pass. -- Success.
Unfortunately, test/test-find-python.js is so fragile that I can not find a way to do this without breaking ALL Python 2 tests. Hopefully someone else can help to make the Python 2 tests pass again. #1826
I tried without success:
The change to gyp/pylib/gyp/generator/ninja.py is lifted right out of #1836 and should be uncontroversial.
The changes to .travis.yml shift to: