Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add test run Node.js 12 & Python 3.7 on macOS #1846

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 24, 2019

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Travis CI: Add test run Node.js 12 & Python 3.7 on macOS

Edit: This test is currently run in allow_failures mode because Linux and macOS share the same env: values.

@cclauss cclauss mentioned this pull request Jul 24, 2019
2 tasks
@cclauss cclauss requested review from joaocgreis and rvagg July 24, 2019 20:50
@joaocgreis joaocgreis mentioned this pull request Jul 24, 2019
2 tasks
@joaocgreis
Copy link
Member

@cclauss good call, there are indeed failures there. If you plan to fix these, you can add the fixes to this PR. If not, this new run should be added to allowed failures.

Just in case it's useful, to quickly see the error locally I use

EXPERIMENTAL_NODE_GYP_PYTHON3=1 NODE_GYP_FORCE_PYTHON=python3 node bin/node-gyp.js rebuild -C test/node_modules/hello_world/ --loglevel=verbose

@cclauss
Copy link
Contributor Author

cclauss commented Jul 24, 2019

The Python 3 on macOS job is already run in allow_failures mode because Linux and macOS share the same env: values. The new test in this PR is really only interesting in combination with #1843, #1844, or #1845.

@cclauss cclauss requested review from refack and sam-github July 24, 2019 21:12
@joaocgreis
Copy link
Member

The failures in test-find-python are fixed in #1843, I think they're safe to ignore here. There are other failures there that show real issues.

@cclauss if you'd prefer, I can include this in #1843 leaving osx python 3 in allowed failures. Would that be better?

@cclauss
Copy link
Contributor Author

cclauss commented Jul 24, 2019

Yes. Please include in #1843 and I am OK with leaving osx python 3 in allow_failures mode.

matrix:
  [ ... ]
  allow_failures:
    - name: "Node.js 12 & Python 3.7 on macOS"

joaocgreis pushed a commit to joaocgreis/node-gyp that referenced this pull request Jul 24, 2019
@cclauss
Copy link
Contributor Author

cclauss commented Jul 25, 2019

Closing in favor of #1843 which now includes these changes.

@cclauss cclauss closed this Jul 25, 2019
@cclauss cclauss deleted the Travis-CI-add-Python3-on-macOS branch July 25, 2019 00:58
joaocgreis pushed a commit that referenced this pull request Jul 26, 2019
Refs: #1846
PR-URL: #1843
Reviewed-By: João Reis <reis@janeasystems.com>
rvagg pushed a commit that referenced this pull request Sep 26, 2019
Refs: #1846
PR-URL: #1843
Reviewed-By: João Reis <reis@janeasystems.com>
@cclauss cclauss added the Python label Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants