Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win: support VS 2017 Desktop Express #1902

Closed
wants to merge 1 commit into from
Closed

win: support VS 2017 Desktop Express #1902

wants to merge 1 commit into from

Conversation

joaocgreis
Copy link
Member

Checklist
  • npm install && npm test passes
  • tests are included
  • commit message follows commit guidelines
Description of change

Visual Studio Express does not install the Microsoft.VisualStudio.Component.VC.Tools.x86.x64 we use to know the Toolset is installed. Since VS Express is not customizable, we can just check for it and keep the current behavior for other editions.

Fixes: #1881

@joaocgreis
Copy link
Member Author

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/157/

rvagg
rvagg approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber-stamp lgtm is all I can offer

@rvagg rvagg mentioned this pull request Oct 2, 2019
Closed
@rvagg
Copy link
Member

rvagg commented Oct 3, 2019

landed in 968c906

@rvagg rvagg closed this Oct 3, 2019
rvagg pushed a commit that referenced this pull request Oct 3, 2019
@joaocgreis @rvagg
win: support VS 2017 Desktop Express
968c906 
Fixes: #1881
PR-URL: #1902
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit that referenced this pull request Oct 3, 2019
@joaocgreis @rvagg
win: support VS 2017 Desktop Express
b0fc071 
Fixes: #1881
PR-URL: #1902
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg rvagg mentioned this pull request Oct 3, 2019
Closed
rvagg pushed a commit that referenced this pull request Oct 4, 2019
@joaocgreis @rvagg
win: support VS 2017 Desktop Express
c169250 
Fixes: #1881
PR-URL: #1902
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit that referenced this pull request Oct 4, 2019
@joaocgreis @rvagg
win: support VS 2017 Desktop Express
735d961 
Fixes: #1881
PR-URL: #1902
Reviewed-By: Rod Vagg <rod@vagg.org>
@DeeDeeG DeeDeeG mentioned this pull request Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't build with Visual Studio 2017 Express
2 participants
@joaocgreis @rvagg