gyp: add __lt__ to MSVSSolutionEntry #1904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
approved these changes
Oct 2, 2019
richardlau
approved these changes
Oct 2, 2019
|
Also seen in the Windows error at nodejs/node-addon-api#445 (comment) and in #1891 |
rvagg
pushed a commit
that referenced
this pull request
Oct 3, 2019
PR-URL: #1904 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>
rvagg
pushed a commit
that referenced
this pull request
Oct 3, 2019
PR-URL: #1904 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>
|
landed in f36bd22 |
rvagg
pushed a commit
that referenced
this pull request
Oct 3, 2019
PR-URL: #1904 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>
rvagg
pushed a commit
that referenced
this pull request
Oct 4, 2019
PR-URL: #1904 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>
rvagg
pushed a commit
that referenced
this pull request
Oct 4, 2019
PR-URL: #1904 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
__cmp__is not used for sorting in Python 3. At least the modulehiredisfails to compile because of this.