-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: try to find python
after python3
#1907
Conversation
Unadorned `python` can be either Python 2 or Python 3, but it is likely to be Python 2 for quite a while. To find Python3, it is recommended to use the explicit name `python3`. See: - https://www.python.org/dev/peps/pep-0394/#for-python-runtime-distributors - #1892 (comment)
I'm not sure what to do about Lines 186 to 210 in f36bd22
I don't have any Windows systems available ATM, so if I duplicate/refactor the Py Launcher stuff to look for 3 first, then 2, I've no way to test, unless its tested in CI, but I'm thinking it isn't. I left it alone for now, though I did switch the order of the Windows default locations: Lines 29 to 30 in f36bd22
|
I agree with this order for v6.0.0:
However, the only acceptable Pythons are 2.7, 3.5, 3.6, and 3.7. So if |
I note with relief that there are some Windows tests in Travis. |
@sam-github The change of order of default locations LGTM. You can simply move the PyLauncher to after the default location check, swap the blocks starting on lines 108 and 115. I plan to review the PyLauncher code for Python 3 sometime, and add registry detection like we have in core. |
@joaocgreis reordered as you suggested, which required some of the test monkey-patching to be adjusted for the new order of |
Unadorned `python` can be either Python 2 or Python 3, but it is likely to be Python 2 for quite a while. To find Python3, it is recommended to use the explicit name `python3`. See: - https://www.python.org/dev/peps/pep-0394/#for-python-runtime-distributors - #1892 (comment) PR-URL: #1907 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: João Reis <reis@janeasystems.com>
landed in dd0e97e, let's pull the trigger then eh? |
Unadorned
python
can be either Python 2 or Python 3, but it is likelyto be Python 2 for quite a while.
To find Python3, it is recommended to use the explicit name
python3
.See:
Checklist
npm install && npm test
passesDescription of change