Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5.x Python compat fixes for README #1911

Closed
wants to merge 7 commits into from
Closed

v5.x Python compat fixes for README #1911

wants to merge 7 commits into from

Commits on Oct 4, 2019

  1. lib: accept Python 3 after Python 2 

    Python 3 is allowed as a compatible Python, but its looked for after
Python 2.

rvagg: removed additional EXPERIMENTAL_NODE_GYP_PYTHON3 in
.travis.yml from a previous commit while landing.

Backport-of: #1844
PR-URL: #1910
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
    @sam-github @rvagg
    sam-github authored and rvagg committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    4215054 View commit details
    Browse the repository at this point in the history

  2. win: support VS 2017 Desktop Express 

    Fixes: #1881
PR-URL: #1902
Reviewed-By: Rod Vagg <rod@vagg.org>
    @joaocgreis @rvagg
    joaocgreis authored and rvagg committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    c169250 View commit details
    Browse the repository at this point in the history

  3. gyp: add __lt__ to MSVSSolutionEntry 

    PR-URL: #1904
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
    @joaocgreis @rvagg
    joaocgreis authored and rvagg committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    d8a71dc View commit details
    Browse the repository at this point in the history

  4. doc: clarify Python configuration, etc 

    Clarify that:
- node-gyp is not used to build Node.js
- PYTHON can be used to add a Python search path
- NODE_GYP_FORCE_PYTHON can be used to override all Python search paths
- That a compatible Python is searched for

PR-URL: #1908
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @sam-github @rvagg
    sam-github authored and rvagg committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    a06be9c View commit details
    Browse the repository at this point in the history

  5. doc: reconcile README with Python 3 compat changes

    @rvagg
    rvagg committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    952f8df View commit details
    Browse the repository at this point in the history

  6. fixup! doc: reconcile README with Python 3 compat changes

    @rvagg
    rvagg committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    1e92969 View commit details
    Browse the repository at this point in the history

  7. fixup! doc: reconcile README with Python 3 compat changes

    @rvagg
    rvagg committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    886dbf4 View commit details
    Browse the repository at this point in the history