Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action: Run Python tests on Ubuntu & macOS #1982

Closed
wants to merge 5 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 2, 2019

Running Python standalone tests on multiple OSes would free up Travis CI for tests of various combinations of Node.js and Python as well as tests on other CPU architectures.
arch: amd64, arm64, ppc64le, s390x

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Running Python standalone tests on multiple OSes would free up Travis CI for tests of various combinations of Node.js and Python as well as tests on other [CPU architectures](https://docs.travis-ci.com/user/multi-cpu-architectures).  __arch: amd64, arm64, ppc64le, s390x__
@rvagg
Copy link
Member

rvagg commented Dec 3, 2019

I'd love if we could push as much as possible to GitHub Actions with a view to one day retiring Travis. What exactly can't we do on Actions yet? Is it just the non-x64 architectures? When they launch self-hosted runners we could start using Node infra to do these ourselves. Not sure what the timeline is on that though.

@cclauss
Copy link
Contributor Author

cclauss commented Dec 3, 2019

@rvagg
Copy link
Member

rvagg commented Dec 4, 2019

nice!

sadly they're still being restrictive on OS/arch support: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-self-hosted-runners#supported-operating-systems-for-self-hosted-runners

but they did talk about making this supported on more permutations and I bet IBM are already talking to them about adding their platforms.

@cclauss
Copy link
Contributor Author

cclauss commented Dec 4, 2019

Can I please get you review on this in its current state? I would be interested to land is so we can start exploring the three todos.

@gengjiawen gengjiawen requested a review from rvagg December 15, 2019 09:49
@rvagg
Copy link
Member

rvagg commented Dec 15, 2019

5a64e9b

@rvagg rvagg closed this Dec 15, 2019
@rvagg rvagg deleted the GitHub-Action-for-Python-tests branch December 15, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants