node-gyp@6.1.0 Release Proposal #2013
Closed
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
changed the title
cclauss
approved these changes
Jan 3, 2020
richardlau
approved these changes
Jan 3, 2020
gengjiawen
approved these changes
Jan 6, 2020
Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> PR-URL: #2011
|
pulled in the outstanding read-to-land PRs to this release:
will give this a couple of days and then release, speak up if you object to releasing with this commit set. |
|
Side note: is it intentional that the npm dist-tag |
|
@vweevers no, it's not! thanks for pointing that out, switched it to 6.0.1. |
|
cleaned up commit order and changelog and published. Python 3.5 still failing in Travis but I'm not treating that as critical and able to hold up releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see #2012 for a v5.x version of this)
95d14cef8f] - doc: remove backticks from Python version list (Rod Vagg) #201126cd6eaea6] - doc: add GitHub Actions badge (doc: add GitHub Actions badge #1994) (Rod Vagg) #1994312c12ef4f] - doc: update macOS_Catalina.md (doc: update macOS_Catalina.md #1992) (James Home) #1992f7b6b6b77b] - doc: fix typo in README.md (Fix typo in README.md #1985) (Suraneti Rodsuwan) #19856b8f2652dd] - doc: add travis badge (Rod Vagg) #197120aa0b44f7] - doc: macOS Catalina add two commands (Christian Clauss) #1962e2bb23d9f5] - gyp: list(dict) so we can del dict(key) while iterating (Christian Clauss) #2009e8f9bee935] - lib: compatibility with semver ≥ 7 (newfor semver.Range) (Xavier Guimard) #20063bcba2a01a] - (SEMVER-MINOR) lib: noproxy support, match proxy detection torequest(Matias Lopez) #1978470cc2178e] - test: remove old docker test harness (test: remove old docker test harness #1993) (Rod Vagg) #199331ecc8421d] - test: add Windows to GitHub Actions testing (test: GitHub Actions add Windows to the testing #1996) (Christian Clauss) #19965a729e86ee] - test: fix typo in header download test (test: fix typo in header download test #2001) (Richard Lau) #2001345c70e56d] - test: direct python invocation & simpler pyenv (Matias Lopez) #1979d6a7e0e1fb] - test: fix macOS Travis on Python 2.7 & 3.7 (Christian Clauss) #19795a64e9bd32] - test: initial Github Actions with Ubuntu & macOS (Christian Clauss) #198504da736d38] - test: fix Python unittests (cclauss) #19610670e5189d] - test: add header download test (Rod Vagg) #1796c506a6a150] - test: configure proper devDir for invoking configure() (Rod Vagg) #1796#1978 is the only novelty and has some breakage potential for edge-cases we haven't considered. It'd be good to get it in the wild to uncover that sooner than later.