build: shrink bloated addon binaries on windows #2060
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm test
passesDescription of change
Closes nodejs/node#29501.
Refs #1118.
Moves build-time optimizations to
node-gyp
to shrink the binary size accidentally bloated by a change tocommon.gypi
in core. Also furthers the goal of decoupling addons from being affected bycommon.gypi
changes.Feel free to tell me if this isn't quite what the issue had in mind and i'll adapt accordingly.
cc @richardlau @deepak1556