chore: remove support for EOL versions of Node.js #2120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
May 11, 2020
gengjiawen
approved these changes
May 11, 2020
|
Nice initiative. +1 on switching to GitHub Actions. Why the failing tests on Py36? |
|
@cclauss i was seeing a bunch of unexplained macOS GitHub Action runner errors earlier today on other repos too - just gave them another kick but i don't think it's related 🤔 the error showed up like this:
which frankly is useless enough that it makes me think Actions itself was just struggling and sounds good - I'll probably follow up with a PR to ditch Travis for Actions if that'd work for y'all |
codebytere
force-pushed
the
remove-eol-versions
branch
from
f9ee264
to
ec171ff
Compare
cclauss
approved these changes
May 12, 2020
|
rvagg
approved these changes
May 13, 2020
|
+1 to Actions, and to adding 14 in there, and switching to Focal, although |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Refs #1945.
Should we also consider moving to GitHub Actions and adding specs for Node.js v14? Feel free to tell me if there's any config code specific to these EOL versions that i missed and i'll ditch it :)
Checklist
npm install && npm testpasses