Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use the "-2" flag with the py.exe launcher on Windows #2131

Closed
wants to merge 2 commits into from
Closed

Don't use the "-2" flag with the py.exe launcher on Windows #2131

wants to merge 2 commits into from
+4 −10

Commits on May 16, 2020

  1. lib: drop "-2" flag for "py.exe" launcher 

    Now that node-gyp supports both Python 2 and Python 3,
We don't need to explicitly try to find only Python 2.

Fixes: nodejs#2130
Refs: https://docs.python.org/3/using/windows.html#launcher
    @DeeDeeG
    DeeDeeG committed May 16, 2020
    Configuration menu
    Copy the full SHA
    7d646ec View commit details
    Browse the repository at this point in the history

  2. test: drop "-2" flag in test-find-python.js 

    We no longer use this flag,
so testing for it would understandably fail!
    @DeeDeeG
    DeeDeeG committed May 16, 2020
    Configuration menu
    Copy the full SHA
    ee0b793 View commit details
    Browse the repository at this point in the history