Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promisify build #2358

Closed
wants to merge 3 commits into from
Closed

feat: promisify build #2358

wants to merge 3 commits into from

Conversation

imatlopez
Copy link
Contributor

@imatlopez imatlopez commented Apr 1, 2021 •
edited
Loading

Checklist
  • npm install && npm test passes
  • tests are included
  • commit message follows commit guidelines
Description of change

An effort to modernize the code and reusing the async motif introduced in #2220

@imatlopez
feat: promisify build
4c3d9d1 
An effort to modernize the code
@imatlopez
feat: consolidate build steps
308b687 
rather than many returns, callback style, use awaits
@imatlopez
fix: expects no response
5b9ea8c
@lukekarrys lukekarrys mentioned this pull request Dec 9, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@imatlopez