-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for native windows arm64 build tools #2650
feat: add support for native windows arm64 build tools #2650
Conversation
bdc65cf
to
fb6c4f3
Compare
fb6c4f3
to
3588133
Compare
38f7778
to
7eba7b2
Compare
@rvagg any chance this could be reviewed & merged? Now that nodejs/node#46228 has been merged and NodeJS itself can be built on arm64 (cross-compilation was already possible), having first-class support in |
Visual Studio 2022 17.4 adds a native C++ compiler for Windows on ARM. This allows arm64 devices to leverage native build tools, leading to a 35% (or more) speed increase. https://devblogs.microsoft.com/visualstudio/arm64-visual-studio-is-officially-here/ Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
7eba7b2
to
b9274c4
Compare
cc @StefanStojanovic @nodejs/platform-windows-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Since GitHub actions are failing in general (not caused by this PR), I pulled this branch and ran tests locally - they passed.
I'm planning to land this PR in one week (26 May), if someone has any objections to this being landed, please express them by then. |
@rvagg @cclauss I'm changing tests from |
You want to merge a PR with |
Yes. Those tests (as is the case in other more recent PRs) are failing because the new |
Checklist
npm install && npm test
passesDescription of change
Visual Studio 2022 17.4 adds a native C++ compiler for Windows on ARM. This allows arm64 devices to leverage native build tools, leading to a 35% (or more) speed increase.
Related announcement from Microsoft: https://devblogs.microsoft.com/visualstudio/arm64-visual-studio-is-officially-here/
Building Signal Desktop's native dependencies on a Surface Pro X (arm64 device):