Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip test when python version is unsupported on platform #2772

Closed
wants to merge 1 commit into from

Conversation

lukekarrys
Copy link
Member

@lukekarrys lukekarrys commented Dec 9, 2022

Checklist
Description of change

python@3.6 is no longer supported on ubuntu-latest (which is now 22.04). See this recent workflow run to see the failure that occurs when the matrix tries to test that combination.

This change makes CI skip all subsequent steps when the setup-python step fails.

One downside to this is that the GitHub UI will still show ✅ for the workflow run instead of indicating that it was skipped.

Alternative options

Instead of this, 3.6 could be dropped from the CI matrix, but I don't know enough about python usage to have an opinion on if that is a good idea.

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.6 is not supported anywhere... https://devguide.python.org/versions

My vote would be to drop Python 3.6 and not make the changes in this PR. Allowing failure and then testing for success sounds dicey and it would be easy to have logic errors that hide important failures.

The other alternative would be to test on Ubuntu 20-04 which still supports Py36.

Another alternative would be to strategy.matrix.exclude Py36 on Ubuntu.

@lukekarrys
Copy link
Member Author

TIL about matrix.exclude which would be a much better idea than the continue-on-error strategy used here.

But if 3.6 is no longer supported than I agree the best idea would be to drop it from the test matrix.

@lukekarrys lukekarrys mentioned this pull request Dec 10, 2022
2 tasks
@lukekarrys
Copy link
Member Author

Closing in favor of #2774

@lukekarrys lukekarrys closed this Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants