Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add note about Python symlinks (PR 2362) to CHANGELOG.md for v9.1.0 #2783

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Jan 4, 2023

Checklist
Description of change

Add an entry for PR #2362 to the CHANGELOG.md for version 9.1.0.

(Details below...)


PR #2362 was merged without a prefixed name, such as "lib:" or "fix:". That means release-please didn't include it in the changelog for v9.1.0.

This change did end up affecting users, though. (See issue #2713 and PR #2721). Therefore, I believe PR #2362 should be noted in the CHANGELOG.md, so users can better understand the behavior they are seeing.

(And of course, I think a fix for the unintended side-effects of #2362 should be merged soon if reasonably possible. See: #2721 for a fix.)

The PR for this change was merged without a prefixed name,
such as "lib:" or "fix:". That means release-please
didn't include it in the changelog for v9.1.0.

This change did end up affecting users, though. (See issue 2713
and PR 2721). Therefore, I believe it should be noted
in the CHANGELOG.md, so users can better understand the behavior
they are seeing.
@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Sep 8, 2023

The present PR adds #2362 to the Changelog properly, whereas it has been missing. I would appreciate a merge, thank you for considering.


For context: My PR #2362 was merged a while ago but never showed in the Changelog. I think it should be in the Changelog, especially since it broke the official Apple-blessed process for signing apps for macOS. Affected users should know which versions are affected by the change (back to 9.1.0).

(Side note: The actual breakage is since fixed in #2721. Considering that fix is in master branch but not in any tagged release yet, it might be good to make a release of node-gyp to get that fix out for the devs trying to sign their apps for macOS.)

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Oct 3, 2023

Sorry to ping again, but can I please get this merged?

(I feel bad about breaking people's stuff, the least anyone can do is document the breakage properly, by having the offending change in the CHANGELOG.)

@cclauss cclauss merged commit b3d41ae into nodejs:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants