Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Replace make-fetch-happen with got #2850

Closed
wants to merge 2 commits into from
Closed

chore: Replace make-fetch-happen with got #2850

wants to merge 2 commits into from

Conversation

legobeat
Copy link

@legobeat legobeat commented May 17, 2023 •
edited
Loading

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Attempt at solving #2848

Alternatives considered:

  • ky: no support for commonjs + node12
  • axios: no support for commonjs + node12 on stable version
  • isomorphic-fetch: unmaintained
  • superagent: big, complex

legobeat added 2 commits May 17, 2023 10:52
@legobeat
fix: Revert "update make-fetch-happen to 11.0.3 (nodejs#2796)"
dc1d443 
This reverts commit 02480f6, thereby
rolling back dependency make-fetch-happen from ^11.0.3 to ^10.0.3.

The upgrade is breaking for node-fetch users as it has transitive
dependencies with syntax incompatible with supported Node.js versions.

Related:
- nodejs#2770
- nodejs#2837
- nodejs#2816
- nodejs#2848
- nodejs#2827
- nodejs#2796
@legobeat
fix: replace make-fetch-happen with got
58039da
@legobeat legobeat mentioned this pull request May 22, 2023
Closed
4 tasks
@cclauss cclauss mentioned this pull request May 24, 2023
Closed
@lukekarrys lukekarrys mentioned this pull request Oct 27, 2023
Merged
@lukekarrys
Copy link
Member

I'd like to stick with make-fetch-happen since I am a maintainer of both and it is helpful to the npm CLI to have the dependency deduped.

Since the dependency issue has been resolved with #2917, I'm going to close this now.

@legobeat Thanks for your patience and hard work to make sure node-gyp got this right! 🎉

@lukekarrys lukekarrys closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @lukekarrys