process.platform will never be kfreebsd #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This platform value came from debian package, and now the value from debian package is simply "freebsd", so this check is useless.
|
Is there anything in the wild still identifying as this? do you have some docs to point to for this, I have zero context on this one. /cc @nodejs/platform-freebsd anyone able to +1 this? |
|
OK, if it's your addition then it can be your removal, still would appreciate a @nodejs/platform-freebsd +1 — also @kapouer, if you're a *BSD person then perhaps you'd consider being on the @nodejs/platform-freebsd group? We have special platform groups that get pinged when there is a platform-specific issue that needs expertise. |
|
Sure, thanks for asking. I'd be glad being more aware of the issues. |
|
LGTM |
rvagg
pushed a commit
that referenced
this pull request
Sep 23, 2015
This platform value came from debian package, and now the value from debian package is simply "freebsd", so this check is useless. PR-URL: #738 Reviewed-By: rvagg Reviewed-By: bnoordhuis Reviewed-By: jbergstroem
|
101bed6, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This platform value came from debian package, and now the value
from debian package is simply "freebsd", so this check is useless.