Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop with zero-length options. #745

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Fix infinite loop with zero-length options. #745

merged 1 commit into from
Sep 25, 2015

Conversation

bnoordhuis
Copy link
Member

The bundled copy of GYP enters an infinite loop when it encounters a
zero-length option so ensure those don't get through.

The root cause is a bad guard in gyp/pylib/gyp/input.py that doesn't
take into account that '' in 'whatever' evaluates to True.

Fixes: #744

R=@rvagg

@TooTallNate
Copy link
Contributor

LGTM

The bundled copy of GYP enters an infinite loop when it encounters a
zero-length option so ensure those don't get through.

The root cause is a bad guard in gyp/pylib/gyp/input.py that doesn't
take into account that `'' in 'whatever'` evaluates to True.

Upstream fix at https://codereview.chromium.org/1364373004/.

Fixes: #744
PR-URL: #745
Reviewed-By: Nathan Rajlich <nathan@tootallnate.net>
@bnoordhuis bnoordhuis merged commit 2ac7de0 into nodejs:master Sep 25, 2015
@bnoordhuis bnoordhuis deleted the fix744 branch September 25, 2015 19:42
@bnoordhuis
Copy link
Member Author

Upstream fix at https://codereview.chromium.org/1364373004/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants