doc: add command options to README.md #937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like this is missing some options, also CC @bnoordhuis |
|
Can you split it into two commits? The new flag looks alright but a code change should not be part of a documentation commit. Also, @Fishrock123 is right that there are plenty more options: |
|
Looking at lib/node-gyp.js, it looks like these are all options. I'll try to get examples added for all of them. And these abbreviations: |
gibfahn
force-pushed
the
docs-fix
branch
2 times, most recently
from
9081f6c
to
09311f4
Compare
Passing --silent is equivalent to passing --loglevel=silent.
gibfahn
force-pushed
the
docs-fix
branch
6 times, most recently
from
2bf72c4
to
514e50a
Compare
|
@bnoordhuis updated, PTAL |
| | `--cafile=$cafile` | Override default CA chain (to download tarball) | ||
| | `--nodedir=$path` | Set the path to the node binary | ||
| | `--python=$path` | Set path to the python (2) binary | ||
| | `--msys_version=$version` | Set Visual Studio version (win) |
There was a problem hiding this comment.
Typo? I think you mean --msvs_version=$version?
Documents options accepted by node-gyp. Continuation of nodejs#880.
bnoordhuis
pushed a commit
that referenced
this pull request
May 31, 2016
Passing --silent is equivalent to passing --loglevel=silent. PR-URL: #937 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks Gibson, landed in ac29d23...4ee3132. |
Closed
zkat
pushed a commit
to npm/npm
that referenced
this pull request
Jun 29, 2016
Headline items: * Fix for Visual Studio 2015 __pfnDliNotifyHook2 failures nodejs/node-gyp#952 * Fix for AIX using fs.statSync nodejs/node-gyp#955 * More verbose msbuild.exe missing error output https://github.com/nodejs/node-gyp/pull/930/files * Added --silent for --loglevel=silent nodejs/node-gyp#937 * Enable V8 deprecation warnings for native addons nodejs/node-gyp#920 Full changelog at https://github.com/nodejs/node-gyp/blob/master/CHANGELOG.md Credit: @rvagg PR-URL: #13199 Reviewed-By: @zkat
zkat
pushed a commit
to npm/npm
that referenced
this pull request
Jun 29, 2016
Headline items: * Fix for Visual Studio 2015 __pfnDliNotifyHook2 failures nodejs/node-gyp#952 * Fix for AIX using fs.statSync nodejs/node-gyp#955 * More verbose msbuild.exe missing error output https://github.com/nodejs/node-gyp/pull/930/files * Added --silent for --loglevel=silent nodejs/node-gyp#937 * Enable V8 deprecation warnings for native addons nodejs/node-gyp#920 Full changelog at https://github.com/nodejs/node-gyp/blob/master/CHANGELOG.md Credit: @rvagg PR-URL: #13200 Reviewed-By: @zkat
zkat
pushed a commit
to npm/npm
that referenced
this pull request
Jun 29, 2016
Headline items: * Fix for Visual Studio 2015 __pfnDliNotifyHook2 failures nodejs/node-gyp#952 * Fix for AIX using fs.statSync nodejs/node-gyp#955 * More verbose msbuild.exe missing error output https://github.com/nodejs/node-gyp/pull/930/files * Added --silent for --loglevel=silent nodejs/node-gyp#937 * Enable V8 deprecation warnings for native addons nodejs/node-gyp#920 Full changelog at https://github.com/nodejs/node-gyp/blob/master/CHANGELOG.md Credit: @rvagg PR-URL: #13199 Reviewed-By: @zkat
zkat
pushed a commit
to npm/npm
that referenced
this pull request
Jun 30, 2016
Headline items: * Fix for Visual Studio 2015 __pfnDliNotifyHook2 failures nodejs/node-gyp#952 * Fix for AIX using fs.statSync nodejs/node-gyp#955 * More verbose msbuild.exe missing error output https://github.com/nodejs/node-gyp/pull/930/files * Added --silent for --loglevel=silent nodejs/node-gyp#937 * Enable V8 deprecation warnings for native addons nodejs/node-gyp#920 Full changelog at https://github.com/nodejs/node-gyp/blob/master/CHANGELOG.md Credit: @rvagg PR-URL: #13199 Reviewed-By: @zkat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents options accepted by node-gyp.
Continuation of #880.
@bnoordhuis