This repository was archived by the owner on Feb 1, 2022. It is now read-only.
fix: Fix takeHeapSnapshot() truncation bug
#58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a logic bug in `takeHeapSnapshot()` where it interpreted the item count as the byte count, resulting in truncated snapshots. This change hinges on the observation that the completion callback always comes after any and all `'addHeapSnapshotChunk'` events. I'm 95% sure after digging into the V8 inspector and its integration with Node.js that the assumption above is correct. If it turns out I'm mistaken, then we will most likely treat that as a bug in Node.js, not node-inspect. Fixes: #56
hybrist
approved these changes
Jan 23, 2018
Collaborator
hybrist
left a comment
hybrist
left a comment
There was a problem hiding this comment.
Thanks for working on this! Sorry, was out sick and then tied down with work for the past week...
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a logic bug in
takeHeapSnapshot()where it interpreted the itemcount as the byte count, resulting in truncated snapshots.
This change hinges on the observation that the completion callback
always comes after any and all
'addHeapSnapshotChunk'events.I'm 95% sure after digging into the V8 inspector and its integration
with Node.js that the assumption above is correct.
If it turns out I'm mistaken, then we will most likely treat that as
a bug in Node.js, not node-inspect.
Fixes: #56