Validate only one report is produced

nodejs · Nov 3, 2016 · f228aa0 · f228aa0
1 parent bea2420
commit f228aa0
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 23 deletions.
diff --git a/test/common.js b/test/common.js
@@ -9,11 +9,11 @@ const REPORT_SECTIONS = [
   'System Information'
 ];
 
-exports.locate = (pid) => {
+exports.findReports = (pid) => {
   // Default NodeReport filenames are of the form NodeReport.<date>.<time>.<pid>.<seq>.txt
   const filePattern = new RegExp('^NodeReport\\.\\d+\\.\\d+\\.' + pid + '\\.\\d+\\.txt$');
-  var files = fs.readdirSync(".");
-  return files.find((file) => filePattern.test(file));
+  const files = fs.readdirSync(".");
+  return files.filter((file) => filePattern.test(file));
 };
 
 exports.validate = (t, report, pid) => {

diff --git a/test/test-api.js b/test/test-api.js
@@ -15,10 +15,9 @@ if (process.argv[2] === 'child') {
     tap.plan(3);
     tap.equal(code, 0, 'Process exited cleanly');
     // Locate and validate the NodeReport
-    const report = common.locate(child.pid);
-    tap.ok(report, 'found report ' + report);
-    if (report) {
-      common.validate(tap, report, child.pid);
-    }
+    const reports = common.findReports(child.pid);
+    tap.equal(reports.length, 1, 'Found reports ' + reports);
+    const report = reports[0];
+    common.validate(tap, report, child.pid);
   });
 };
diff --git a/test/test-exception.js b/test/test-exception.js
@@ -29,10 +29,9 @@ if (process.argv[2] === 'child') {
     tap.equal(signal, expectedSignal, 'Process should exit with signal ' + expectedSignal);
 
     // Locate and validate the NodeReport
-    const report = common.locate(child.pid);
-    tap.ok(report, 'found report ' + report);
-    if (report) {
-      common.validate(tap, report, child.pid);
-    }
+    const reports = common.findReports(child.pid);
+    tap.equal(reports.length, 1, 'Found reports ' + reports);
+    const report = reports[0];
+    common.validate(tap, report, child.pid);
   });
 };
diff --git a/test/test-fatal-error.js b/test/test-fatal-error.js
@@ -26,10 +26,9 @@ if (process.argv[2] === 'child') {
     tap.plan(3);
     tap.notEqual(code, 0, 'Process should not exit cleanly');
     // Locate and validate the NodeReport
-    const report = common.locate(child.pid);
-    tap.ok(report, 'found report ' + report);
-    if (report) {
-      common.validate(tap, report, child.pid);
-    }
+    const reports = common.findReports(child.pid);
+    tap.equal(reports.length, 1, 'Found reports ' + reports);
+    const report = reports[0];
+    common.validate(tap, report, child.pid);
   });
 };
diff --git a/test/test-signal.js b/test/test-signal.js
@@ -56,10 +56,9 @@ if (process.argv[2] === 'child') {
     tap.equal(code, null, 'Process should not exit cleanly');
     tap.equal(signal, 'SIGTERM', 'Process should exit with SIGTERM');
     // Locate and validate the NodeReport
-    const report = common.locate(child.pid);
-    tap.ok(report, 'found report ' + report);
-    if (report) {
-      common.validate(tap, report, child.pid);
-    }
+    const reports = common.findReports(child.pid);
+    tap.equal(reports.length, 1, 'Found reports ' + reports);
+    const report = reports[0];
+    common.validate(tap, report, child.pid);
   });
 };