This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Remove setCoreDump
#126
Merged
Remove setCoreDump
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Node.js 6: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/304/ (✔️) (Node.js 12/master would fail until #125 is merged). |
sam-github
approved these changes
Mar 30, 2019
The native binding doesn't actually export a `setCoreDump` method so we were exporting `undefined` instead of an actual function. PR-URL: nodejs#126 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
richardlau
force-pushed
the
remove-setcoredump
branch
from
d5fc025
to
6ee4a66
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native binding doesn't actually export a
setCoreDumpmethod sowe were exporting
undefinedinstead of an actual function.