This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Restore uppercase C++ method names #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Node.js 6: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/308/ (:heavy_check_mark:) |
sam-github
approved these changes
Apr 2, 2019
fabac78 changed the exported C++ method names to start with a lower case character to match the name exported to JavaScript land. This turns out to be unnecessary if `Nan::SetMethod()` is used instead of `NAN_EXPORT()`. Restore the original casing of the C++ methods to be consistent with the non-exported C++ methods. PR-URL: nodejs#127 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fabac78 changed the exported C++ method names to start with a lower case
character to match the name exported to JavaScript land. This turns out
to be unnecessary if
Nan::SetMethod()is used instead ofNAN_EXPORT(). Restore the original casing of the C++ methods to beconsistent with the non-exported C++ methods.
Refs: #125 (comment)
cc @sam-github