Fixes/port for node-report on z/OS: #129
Conversation
gabylb
commented
May 13, 2019
gabylb
commented
- Fix compiler errors
- Change ebcdic output to ascii
- Native Stack Trace and JavaScript Stack Trace
- Command line
- Loaded libraries
- Hostname
- Filename output in fs_event
- Listening socket tcp uv handle
- OS Version check
- Fix compiler errors - Change ebcdic output to ascii - Native Stack Trace and JavaScript Stack Trace - Command line - Loaded libraries - Hostname - Filename output in fs_event - Listening socket tcp uv handle - OS Version check
|
cc @nodejs/platform-s390 |
|
I've been able to verify that these changes work with an internal IBM build of https://github.com/ibmruntimes/node/tree/v8.16.0.zos. They don't work with the current publicly available Node.js 8 on z/OS public beta (based on v8.15.1). Which leads to the question of maintaining z/OS support if we land this. While we do have z/OS machines in the community CI (used for building libuv) I don't really want to have to build Node.js from source (as it will add a lot of time to the CI runs). So it looks like we'll be reliant on the z/OS folks at IBM to keep an eye on the module and update as necessary. cc @nodejs/platform-s390 @mhdawson @gabylb @IgorTodorovskiIBM CI runs to show these changes don't break existing platform support: |
|
@richardlau would it be possible to setup a CI job in the community which pulls the Node.js binaries that @IgorTodorovskiIBM team's provides and then run the node-report tests. We might even be able to have his team/the IBM Node.js add those binaries to the z/OS machines when they are released to make it even easier? |
|
@IgorTodorovskiIBM, @joransiu any thoughts on my last comment? |
|
@mhdawson: I think that's a good idea. |
|
Final checks before merging: |
