This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Fix for failure in fatal error (OOM) test #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On v6.9.1 we get a second OOM in v8 if we call the stacktrace API in the fatal error (OOM) scenario. It worked OK on v6.3.0. Fix is to remove the call for now. This means we won't provide a JS stacktrace in the NodeReport for this particular scenario. The v8 stderr output does show a single JS frame, so we may be able to obtain that for nodereport via another route at some point.
|
While I agree that investigating to see if we can provide a stack trace, this change seems reasonable so that we don't have test failures and then we can add back what is necessary when/if we can provide the stack trace. |
mhdawson
approved these changes
Nov 4, 2016
|
Unless there are objections before then will plan to land tomorrow. |
|
No objections here. Be good to get the tests passing 😄 |
mhdawson
pushed a commit
that referenced
this pull request
Nov 9, 2016
On v6.9.1 we get a second OOM in v8 if we call the stacktrace API in the fatal error (OOM) scenario. It worked OK on v6.3.0. Fix is to remove the call for now. This means we won't provide a JS stacktrace in the NodeReport for this particular scenario. The v8 stderr output does show a single JS frame, so we may be able to obtain that for nodereport via another route at some point. PR-URL: #16 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed as 94a1125 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #12
On v6.9.1 we get a second OOM in v8 if we call the v8 stacktrace API in the fatal error (OOM) scenario. It worked OK on v6.3.0. Fix is to remove the call for now, for the fatal error (OOM) scenario. There was an additional check to avoid the call if we failed actually inside GC, this is also removed as it is now redundant.
This means we won't provide a JS stacktrace in the NodeReport for this particular scenario. The v8 stderr output does show a single JS frame, so we may be able to obtain that for nodereport via another route at some point. Alternatively we can investigate why the v8 API is failing and see if that can be improved.