This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Fix return code from uncaught exception handler #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on on node 4 and 6, with node-report enabled, the uncaught exception handler produces a report then prints a stack trace, but node continues rather than exiting with rc=1. Fix return code and testcase.
|
LGTM |
richardlau
approved these changes
Mar 8, 2017
There was a problem hiding this comment.
LGTM
Expected exit codes for Node.js are documented: https://nodejs.org/dist/latest-v6.x/docs/api/process.html#process_exit_codes
cjihrig
approved these changes
Mar 9, 2017
rnchamberlain
added a commit
that referenced
this pull request
Mar 16, 2017
When running on on node 4 and 6, with node-report enabled, the uncaught exception handler produces a report then prints a stack trace, but node continues rather than exiting with rc=1. Fix return code and testcase. PR-URL: #70 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed as fe6cce6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On node 4 or 6, the uncaught exception handler produces a report then prints a stack trace OK, but node continues to run when the handler function returns. The expected behavior on uncaught exception is to exit with rc=1. This PR fixes the handler to exit with return code = 1, also fixes the corresponding testcase.
Fixes #6
CI: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/118/