Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claims that PR is not accepted yet #8

Closed
sam-github opened this issue Mar 23, 2017 · 4 comments
Closed

claims that PR is not accepted yet #8

sam-github opened this issue Mar 23, 2017 · 4 comments

Comments

@sam-github
Copy link

Oh, no! I don't think I can live without node-review anymore, and its not working for me with nodejs/node#5923

It claims

Error: This pull request is not yet ready to land. 
The following reviewers have requested changes: 

Yes, that is the empty list, because all reviewers have accepted the changes. Just me, or is it a problem for other people? I haven't landed any changes for almost 2 weeks (vacation, travel), so I don't know if this is new or not.

I wonder if its coincidental that I recently reported a bug to github where some reviewers listed in the conversation review summary at the bottom of the thread were not listed in the review area at the top-right of the page, a problem they fixed a week or so ago.

@vsemozhetbyt
Copy link

I see a proper result there:

PR Metadata

PR-URL: https://github.com/nodejs/node/pull/5923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Google Chrome 59.0.3048.0 Canary

@evanlucas
Copy link
Contributor

Are you using the latest version? That pr did not work for either until I pulled the latest from master and then reloading the extension.

@sam-github
Copy link
Author

That was the issue, out of date, thanks. I forgot that this hadn't been installed normally, and the extension doesn't auto-update. Its working after update.

@evanlucas
Copy link
Contributor

Glad you got it working. I really need to get it published to the chrome app store, just haven't had a chance to. I'll try to do that sometime this week or next...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants