improved makeCallback arg checking

nodejs · Feb 14, 2015 · 3a37851 · 3a37851
1 parent b510fbd
commit 3a37851
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/fs.js b/lib/fs.js
@@ -91,9 +91,12 @@ function maybeCallback(cb) {
 // for callbacks that are passed to the binding layer, callbacks that are
 // invoked from JS already run in the proper scope.
 function makeCallback(cb) {
-  if (!util.isFunction(cb)) {
+  if (util.ifNullOrUndefined(cb)) {
     return rethrow();
   }
+  if (!util.isFunction(cb)) {
+    throw new Error('callback must be a function');
+  }
 
   return function() {
     return cb.apply(null, arguments);