child_process.fork: don't modify args

Fixes #1888.
nodejs · Oct 14, 2011 · a09b747 · a09b747
1 parent e0297ca
commit a09b747
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -124,7 +124,7 @@ function nop() { }
 exports.fork = function(modulePath, args, options) {
   if (!options) options = {};
 
-  if (!args) args = [];
+  args = args ? args.slice(0) : [];
   args.unshift(modulePath);
 
   if (options.stdinStream) {

diff --git a/test/simple/test-child-process-fork.js b/test/simple/test-child-process-fork.js
@@ -1,8 +1,10 @@
 var assert = require('assert');
 var common = require('../common');
 var fork = require('child_process').fork;
+var args = ['foo', 'bar'];
 
-var n = fork(common.fixturesDir + '/child-process-spawn-node.js');
+var n = fork(common.fixturesDir + '/child-process-spawn-node.js', args);
+assert.deepEqual(args, ['foo', 'bar']);
 
 var messageCount = 0;