Read up the prototype of the 'env' object.

Closes GH-713.
nodejs · Feb 25, 2011 · a9a252f · a9a252f
1 parent 8a50f23
commit a9a252f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -215,8 +215,7 @@ ChildProcess.prototype.spawn = function(path, args, options, customFds) {
 
   var envPairs = [];
   var keys = Object.keys(env);
-  for (var index = 0, keysLength = keys.length; index < keysLength; index++) {
-    var key = keys[index];
+  for (var key in env) {
     envPairs.push(key + '=' + env[key]);
   }
 

diff --git a/test/simple/test-child-process-env.js b/test/simple/test-child-process-env.js
@@ -2,7 +2,15 @@ var common = require('../common');
 var assert = require('assert');
 
 var spawn = require('child_process').spawn;
-var child = spawn('/usr/bin/env', [], {env: {'HELLO': 'WORLD'}});
+
+var env = {
+  'HELLO': 'WORLD'
+};
+env.__proto__ = {
+  'FOO': 'BAR'
+}
+
+var child = spawn('/usr/bin/env', [], {env: env});
 
 var response = '';
 
@@ -15,4 +23,5 @@ child.stdout.addListener('data', function(chunk) {
 
 process.addListener('exit', function() {
   assert.ok(response.indexOf('HELLO=WORLD') >= 0);
+  assert.ok(response.indexOf('FOO=BAR') >= 0);
 });