Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
build: disable -fstrict-aliasing for any gcc < 4.6.0
Browse files Browse the repository at this point in the history
It has been conclusively demonstrated that the -fstrict-aliasing bugs in gcc's
optimizer are not limited to the 4.5.x releases only.

Fixes #3601 among others.
  • Loading branch information
bnoordhuis committed Jul 3, 2012
1 parent a0add91 commit b731c96
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -287,12 +287,9 @@ def configure_node(o):
# turn off strict aliasing if gcc < 4.6.0 unless it's llvm-gcc
# see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45883
# see http://code.google.com/p/v8/issues/detail?id=884
o['variables']['strict_aliasing'] = b(is_clang or cc_version >= (4,6,0))

# disable strict aliasing in V8 if we're compiling with gcc 4.5.x,
# it makes V8 crash in various ways
o['variables']['v8_no_strict_aliasing'] = b(
not is_clang and (4,5,0) <= cc_version < (4,6,0))
strict_aliasing = is_clang or cc_version >= (4,6,0)
o['variables']['strict_aliasing'] = b(strict_aliasing)
o['variables']['v8_no_strict_aliasing'] = b(not strict_aliasing)

# clang has always supported -fvisibility=hidden, right?
if not is_clang and cc_version < (4,0,0):
Expand Down

0 comments on commit b731c96

Please sign in to comment.