Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
build: build addons into the "build" dir instead of "out"
Browse files Browse the repository at this point in the history 
This matches the old node-waf system. Having two different dirs for this stuff
is dumb.
  • Loading branch information
@TooTallNate @isaacs
TooTallNate authored and isaacs committed Feb 27, 2012
1 parent cacd651 commit ba0892b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/gyp_addon
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import sys
script_dir = os.path.dirname(__file__)
node_root = os.path.abspath(os.path.join(script_dir, os.pardir))
if sys.platform == 'win32':
output_dir = os.path.join(os.getcwd(), 'out')
output_dir = os.path.join(os.getcwd(), 'build')
else:
output_dir = 'out'
output_dir = 'build'

sys.path.insert(0, os.path.join(node_root, 'tools', 'gyp', 'pylib'))
import gyp
Expand Down

2 comments on commit ba0892b

@bnoordhuis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of liked out/ actually, what with shorter being better and all that.

@TooTallNate
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had gotten used to out as well, but I think in this case backwards-compatibility is a better argument.

Please sign in to comment.